[WAYP-2172] Set variable options for add-on definitions #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladin-devops
force-pushed
the
WAYP-2172-add-on-variable-options
branch
from
394d397
to
e5db712
Compare
paladin-devops
force-pushed
the
WAYP-2396-waypoint-input-vars
branch
from
23f793f
to
162b417
Compare
paladin-devops
force-pushed
the
WAYP-2172-add-on-variable-options
branch
from
6f63343
to
9bea587
Compare
paladin-devops
force-pushed
the
WAYP-2396-waypoint-input-vars
branch
from
454a6b3
to
9962d62
Compare
paladin-devops
force-pushed
the
WAYP-2172-add-on-variable-options
branch
from
9bea587
to
3340c01
Compare
paladin-devops
force-pushed
the
WAYP-2396-waypoint-input-vars
branch
from
3d04248
to
d06db61
Compare
paladin-devops
force-pushed
the
WAYP-2172-add-on-variable-options
branch
2 times, most recently
from
0be6729
to
fe0c8e4
Compare
|
Converted this back to draft while I update it based on feedback which applied to #816. |
paladin-devops
force-pushed
the
WAYP-2172-add-on-variable-options
branch
from
7c1421f
to
6390bd3
Compare
Also fix required vs. computed property on variable options field for data source.
paladin-devops
force-pushed
the
WAYP-2172-add-on-variable-options
branch
from
232bd57
to
c2a287a
Compare
HenryEstberg
approved these changes
Apr 29, 2024
delores-hashicorp
approved these changes
Apr 30, 2024
catsby
approved these changes
May 3, 2024
| Description: "List of options", | ||
| }, | ||
| "user_editable": &schema.BoolAttribute{ | ||
| Required: true, |
There was a problem hiding this comment.
This is Optional in resource_waypoint_application_template.go. I believe it also needs to be Computed: true
There was a problem hiding this comment.
Updated in 81d1757 (for both templates and add-on definitions).
| @@ -10,7 +10,7 @@ import ( | |||
|
|
|||
| sharedmodels "github.com/hashicorp/hcp-sdk-go/clients/cloud-shared/v1/models" | |||
| "github.com/hashicorp/hcp-sdk-go/clients/cloud-waypoint-service/preview/2023-08-18/client/waypoint_service" | |||
| waypointmodels "github.com/hashicorp/hcp-sdk-go/clients/cloud-waypoint-service/preview/2023-08-18/models" | |||
| waypoint_models "github.com/hashicorp/hcp-sdk-go/clients/cloud-waypoint-service/preview/2023-08-18/models" | |||
There was a problem hiding this comment.
nit: this should be waypointModels but we can do a sweep later, I think a few other resources have the _ as well
Also update package alias name for Waypoint models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
This PR updates the hcp_waypoint_add_on_definition resource and data source to set and retrieve input variable options for HCP Waypoint add-ons.
🏗️ Acceptance tests
Output from acceptance testing: