Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add-on resources and data sources now retrieve output values. #822

Merged
merged 6 commits into from
May 20, 2024
Merged

Add-on resources and data sources now retrieve output values. #822

merged 6 commits into from
May 20, 2024

Conversation

HenryEstberg
Copy link
Contributor

@HenryEstberg HenryEstberg commented Apr 24, 2024 •
edited
Loading

🛠️ Description

This updates the hcp_waypoint_add_on resource and data source to read Terraform output values, when present.

In addition, it bumps hcp-sdk-go to v0.96.0

To test:

$ make testacc TESTARGS='-run=TestAccWaypoint_Add_On_basic'
$ make testacc TESTARGS='-run=TestAccWaypointData_Add_On_basic'

@HenryEstberg HenryEstberg marked this pull request as ready for review May 2, 2024 18:09
@HenryEstberg HenryEstberg requested review from a team as code owners May 2, 2024 18:09
manish-hashicorp
manish-hashicorp approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@manish-hashicorp manish-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping. Please get review from your team before merging.

evanphx
evanphx reviewed May 6, 2024
View reviewed changes
Copy link

@evanphx evanphx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we do the conversion 4 times because of different ways to access it. The code looks pretty much identical, should we refactor it so there is only one place that does the conversion? A simple helper function perhaps?

@HenryEstberg HenryEstberg merged commit 3c18883 into main May 20, 2024
6 checks passed
@HenryEstberg HenryEstberg deleted the hcp-waypoint-add-on-outputs branch May 20, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanphx evanphx evanphx left review comments

@manish-hashicorp manish-hashicorp manish-hashicorp approved these changes

@paladin-devops paladin-devops paladin-devops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HenryEstberg @evanphx @manish-hashicorp @paladin-devops