Adding check to ensure that length for random_string and random_passw…

…ord >= min_upper + min_lower + min_numeric _ min_special (#233)

internal/provider/resource_string_test.go

@@ -64,6 +64,10 @@ func TestAccResourceString(t *testing.T) {
 				ImportStateVerify:       true,
 				ImportStateVerifyIgnore: []string{"length", "lower", "number", "special", "upper", "min_lower", "min_numeric", "min_special", "min_upper", "override_special"},
 			},
+			{
+				Config:      testAccResourceStringInvalidConfig,
+				ExpectError: regexp.MustCompile("Error running apply: exit status 1"),
+			},
 		},
 	})
 }
@@ -153,4 +157,9 @@ resource "random_string" "min" {
   min_numeric = 4
 }
 `
+	testAccResourceStringInvalidConfig = `
+resource "random_string" "invalid_length" {
+  length = 2
+  min_lower = 3
+}`
 )

internal/provider/string.go

@@ -6,6 +6,7 @@ package provider
 import (
 	"context"
 	"crypto/rand"
+	"fmt"
 	"math/big"
 	"sort"
 
@@ -144,6 +145,13 @@ func createStringFunc(sensitive bool) func(_ context.Context, d *schema.Resource
 		minSpecial := d.Get("min_special").(int)
 		overrideSpecial := d.Get("override_special").(string)
 
+		if length < minUpper+minLower+minNumeric+minSpecial {
+			return append(diags, diag.Diagnostic{
+				Severity: diag.Error,
+				Summary:  fmt.Sprintf("length (%d) must be >= min_upper + min_lower + min_numeric + min_special (%d)", length, minUpper+minLower+minNumeric+minSpecial),
+			})
+		}
+
 		if overrideSpecial != "" {
 			specialChars = overrideSpecial
 		}