Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Breaking change of null keeper values between 3.3.2 and 3.4.0 #305

Merged
merged 16 commits into from
Sep 2, 2022

Conversation

bendbennett
Copy link
Contributor

Closes: #303

@bendbennett bendbennett added the bug label Sep 1, 2022
@bendbennett bendbennett requested a review from a team as a code owner September 1, 2022 18:57
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes outside mine look good to me 🚀

@@ -50,7 +50,7 @@ jobs:
name: 'Acc. Tests (OS: ${{ matrix.os }} / TF: ${{ matrix.terraform }})'
needs: build
runs-on: ${{ matrix.os }}
timeout-minutes: 15
timeout-minutes: 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this pull request, but we can try to avoid this ever growing timeout issue by switching testing to using resource.ParallelTest() (which calls (*testing.T).Parallel() under the hood) and passing the -parallel flag to the go test command.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change of null keeper values between 3.3.2 and 3.4.0
2 participants