Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for externally managed Group Member IDs to Vault Identity Group #1630

Merged
merged 9 commits into from
Oct 26, 2022
Merged

Add support for externally managed Group Member IDs to Vault Identity Group #1630

merged 9 commits into from
Oct 26, 2022

Conversation

vinay-gopalan
Copy link
Contributor

@vinay-gopalan vinay-gopalan commented Oct 11, 2022 •
edited
Loading

This PR adds a new resource vault_identity_group_member_group_ids that allows users to manage Group Member IDs for Identity Groups externally.

Closes #1371

Output from acceptance tests:

make testacc TESTARGS='-run=TestAccIdentityGroupMemberGroupIdsNonExclusive
=== RUN   TestAccIdentityGroupMemberGroupIdsNonExclusive
--- PASS: TestAccIdentityGroupMemberGroupIdsNonExclusive (4.54s)
PASS

@vinay-gopalan vinay-gopalan changed the title Add support for Group Member IDs to Vault Identity Group Add support for externally managed Group Member IDs to Vault Identity Group Oct 11, 2022
@benashz benashz added this to the 3.10.0 milestone Oct 11, 2022
benashz
benashz reviewed Oct 12, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial refactoring looks good. I like your approach. I think there are a few bits more than can be done to further reduce some of the code duplication between entity_ids and group_ids e.g. in the CRUD funcs. Also it would be good to update to field constants whenever possible.

internal/identity/group/group.go Outdated Show resolved Hide resolved
internal/identity/group/group.go Show resolved Hide resolved
internal/identity/group/group.go Outdated Show resolved Hide resolved
internal/identity/group/group.go Outdated Show resolved Hide resolved
internal/identity/group/group.go Outdated Show resolved Hide resolved
internal/identity/group/group.go Outdated Show resolved Hide resolved
vault/resource_identity_group_member_entity_ids.go Outdated Show resolved Hide resolved
vault/resource_identity_group_member_group_ids.go Outdated Show resolved Hide resolved
vault/resource_identity_group_member_group_ids.go Outdated Show resolved Hide resolved
vault/resource_identity_group_member_group_ids.go Outdated Show resolved Hide resolved
benashz
benashz reviewed Oct 26, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some comments/nits still to address.

internal/identity/group/group.go Show resolved Hide resolved
vault/resource_identity_entity_test.go Show resolved Hide resolved
vault/resource_identity_group.go Show resolved Hide resolved
internal/identity/group/group.go Outdated Show resolved Hide resolved
internal/identity/group/group.go Outdated Show resolved Hide resolved
benashz
benashz approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinay-gopalan vinay-gopalan merged commit a12c693 into main Oct 26, 2022
@vinay-gopalan vinay-gopalan deleted the VAULT-8350/identity-member-groupids branch October 26, 2022 21:46
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@vinay-gopalan
Add support for externally managed Group Member IDs to Vault Identity…
5963771 
… Group (hashicorp#1630)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
documentation size/XL
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

Feature Request - identity_group_member - Enable adding group_id's as members of internal groups
2 participants
@vinay-gopalan @benashz