Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add use_sts_region_from_client to AWS Auth Config #1963

Merged
merged 7 commits into from
Aug 14, 2023
Merged

Add use_sts_region_from_client to AWS Auth Config #1963

merged 7 commits into from
Aug 14, 2023
+77 −5

Conversation

raymonstah
Copy link
Contributor

@raymonstah raymonstah commented Jul 28, 2023 •
edited
Loading

Adds a new field use_sts_region_from_client to the AWS auth config.

This feature will be available when hashicorp/vault#21960 is released. Set for Vault v1.15.

@raymonstah raymonstah requested a review from a team July 28, 2023 18:16
@raymonstah raymonstah marked this pull request as ready for review July 28, 2023 18:18
@raymonstah raymonstah changed the title Vault 18389/add sts region from client field Add use_sts_region_from_client to AWS Auth Config Jul 28, 2023
vinay-gopalan
vinay-gopalan reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Could we also add docs for this field, thanks!

vault/resource_aws_auth_backend_client.go Show resolved Hide resolved
vault/resource_aws_auth_backend_client_test.go Show resolved Hide resolved
fairclothjm
fairclothjm approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fairclothjm fairclothjm added this to the 3.19.0 milestone Jul 28, 2023
vinay-gopalan
vinay-gopalan approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Had one small comment, but good to go otherwise 🎉

website/docs/r/aws_auth_backend_client.html.md Outdated Show resolved Hide resolved
@vinay-gopalan vinay-gopalan removed this from the 3.19.0 milestone Aug 2, 2023
@raymonstah raymonstah added this to the 3.20.0 milestone Aug 14, 2023
@raymonstah raymonstah merged commit 6893edf into main Aug 14, 2023
9 checks passed
@raymonstah raymonstah deleted the VAULT-18389/add-sts_region_from_client-field branch August 14, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairclothjm fairclothjm fairclothjm approved these changes

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
documentation size/M
Projects
None yet
Milestone
3.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raymonstah @fairclothjm @vinay-gopalan