Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth/approle: set sensitive for secret values #2008

Merged
merged 2 commits into from
Oct 2, 2023
Merged

auth/approle: set sensitive for secret values #2008

merged 2 commits into from
Oct 2, 2023

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Sep 8, 2023 •
edited
Loading

Description

Closes #968

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@fairclothjm fairclothjm requested a review from a team September 8, 2023 21:45
@fairclothjm fairclothjm added this to the 3.21.0 milestone Oct 2, 2023
robmonte
robmonte approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@robmonte robmonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@fairclothjm fairclothjm merged commit 4a5cd4a into main Oct 2, 2023
12 checks passed
@fairclothjm fairclothjm deleted the approle-login-sensitive branch October 2, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robmonte robmonte robmonte approved these changes

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
3.21.0
Development

Successfully merging this pull request may close these issues.

Secret ID and Client Token is shown on approle auth backend login plan
3 participants
@fairclothjm @robmonte @vinay-gopalan