GCP Auth: Modifying incorrect audience string for GCE #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conor-mccullough
changed the title
fairclothjm
reviewed
Oct 24, 2023
There was a problem hiding this comment.
Thanks @conor-mccullough! Yes, we would appreciate a changelog entry!
|
Cheers @fairclothjm - Added to the changelog |
fairclothjm
reviewed
Oct 25, 2023
fairclothjm
approved these changes
Oct 25, 2023
|
Thanks again @conor-mccullough ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initially raised by ent customer via issue 2055, then via Zendesk in an official support engagement.
Unsure whether this requires a changelog entry - please let me know if so and I'll update the PR.
Output from acceptance testing:
Test results uploaded internally via Jira, can upload here too if needed
Community Note