Handle out-of-band approle deletion #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinay-gopalan
commented
Feb 14, 2024
| @@ -37,6 +37,18 @@ func TestAccAppRoleAuthBackendRoleSecretID_basic(t *testing.T) { | |||
| resource.TestCheckResourceAttrSet(secretIDResource, "accessor"), | |||
| ), | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Confirmed that this test will fail on main and successfully apply and pass with the fixes in this PR
fairclothjm
reviewed
Feb 14, 2024
| @@ -388,3 +415,7 @@ func approleAuthBackendRoleSecretIDParseID(id string) (backend, role, accessor s | |||
|
|
|||
| return | |||
| } | |||
|
|
|||
| func isAppRoleDoesNotExistError(err error, role string) bool { | |||
| return util.Is500(err) && strings.Contains(err.Error(), fmt.Sprintf("role \"%s\" does not exist", role)) | |||
There was a problem hiding this comment.
Nice! I was thinking this week about these types of scenarios and we probably don't always handle them correctly like this.
vinay-gopalan
deleted the
VAULT-24123/handle-approle-out-of-band-deletion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the AppRole Secret ID resource from TF state when a 500 error is returned from the Vault server upon an out-of-band deletion of the AppRole. Previously, all subsequent runs of TF would fail with the error. Ideally we should remove the non-existent secret ID from state and allow the TFVP to recreate the role and secret ID.
Closes #1683 #1666
Checklist
Output from acceptance testing: