Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secrets sync: add missing fields for azure sync destination #2247

Merged
merged 2 commits into from
May 24, 2024
Merged

secrets sync: add missing fields for azure sync destination #2247

merged 2 commits into from
May 24, 2024
+7 −0

Conversation

fairclothjm
Copy link
Contributor

Description

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@fairclothjm fairclothjm added this to the 4.3.0 milestone May 24, 2024
@fairclothjm fairclothjm merged commit ff0c4ca into main May 24, 2024
1 of 2 checks passed
@fairclothjm fairclothjm deleted the secrets-sync/dest/azure branch May 24, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

@robmonte robmonte Awaiting requested review from robmonte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fairclothjm @vinay-gopalan