aws_secret_backend_role: support role_arns argument #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws_secret_backend_role: support role_arns argument
ghost
added
| @@ -70,6 +70,16 @@ func awsSecretBackendRoleResource() *schema.Resource { | |||
| Required: true, | |||
| Description: "Role credential type.", | |||
| }, | |||
| "role_arns": { | |||
There was a problem hiding this comment.
Do role_arns conflict with other fields in practice? The documentation doesn't say it does. Should we remove it from the conflicts with clauses?
There was a problem hiding this comment.
policy_documentapparently does not conflict withrole_arns(see test using both), so I've removed the ConflictsWith clause for this onepolicy_arnsandpolicy_arnare only valid whencredential_typeisiam_user, whilerole_arnsis only valid whencredential_typeisassumed_roleand prohibited otherwise (per the doc), so in practice, they are mutually exclusive- for
policy, the doc says "cannot be mixed with the parameters listed above", hence theConflictsWithclause
| roleARNs = append(roleARNs, roleIfc.(string)) | ||
| } | ||
|
|
||
| if policy == "" && len(policyARNs) == 0 && len(roleARNs) == 0 { |
There was a problem hiding this comment.
Not sure this check is needed.
There was a problem hiding this comment.
Are you talking about the whole if { } or just the && len(roleARNs) == 0 part?
|
+1 |
|
Could you please make release out of this change? Desperately need this feature |
|
+1 |
|
+1 |
|
@tyrannosaurus-becks any chance you can take a second look soon? 😄 |
tyrannosaurus-becks
approved these changes
Jun 3, 2019
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
aws_secret_backend_role: support role_arns argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support in the provider for the
role_arnsparameter of AWS secret backend roles, added in Vault 0.11.