-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support tls_ca and tls_certificate_key for mongodb connections #822
Open
cyrus-mc
wants to merge
5
commits into
hashicorp:main
Choose a base branch
from
cyrus-mc:mongodb_tls_options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
size/S
label
Jul 19, 2020
…on_url to support root credential rotation
Is this PR dead or alive? I'd like to add similar functionality for MySQL, given Vault 1.5.0 supports mTLS for MySQL hashicorp/vault#9181 now. If it's not being worked on we'd like to take this as a base, add MySQL stuff and fix tests. cc @cyrus-mc |
Closed with #1146 |
@cyrus-mc Hi, are you still interested in carrying this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Add TLS options to MongoDB database connection to allow verification of certificate as well as client auth. This is in line with the CLI options .
Output from acceptance testing: