Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview results of Vault PR 21723 #190

Closed
wants to merge 3 commits into from
Closed

Preview results of Vault PR 21723 #190

wants to merge 3 commits into from

Conversation

maxb
Copy link
Contributor

@maxb maxb commented Jul 10, 2023

See: hashicorp/vault#21723

apidiff (root and schema):

Incompatible changes:
- (*Auth).GithubReadTeams: removed
- (*Auth).GithubReadUsers: removed
- (*System).PoliciesList: removed
Compatible changes:
- (*Auth).GithubListTeams: added
- (*Auth).GithubListUsers: added
- (*Secrets).CubbyholeList: added
- (*Secrets).KvV1List: added
- (*Secrets).KvV2ListMetadata: added
- (*System).RawList: added
- (*System).RawListPath: added

Incompatible changes:
- NewPoliciesListResponseWithDefaults: removed
- PoliciesListResponse: removed
Compatible changes:
- KvV1ListResponse: added
- KvV2ListMetadataResponse: added
- NewKvV1ListResponseWithDefaults: added
- NewKvV2ListMetadataResponseWithDefaults: added
- NewRawListPathResponseWithDefaults: added
- NewRawListResponseWithDefaults: added
- RawListPathResponse: added
- RawListResponse: added

How has this been tested?

Not yet, just a draft PR to showcase future changes.

See: hashicorp/vault#21723

apidiff (root and schema):
```
Incompatible changes:
- (*System).PoliciesList: removed
Compatible changes:
- (*Auth).GithubListTeams: added
- (*Auth).GithubListUsers: added
- (*Secrets).CubbyholeList: added
- (*Secrets).KvV1List: added
- (*Secrets).KvV2ListMetadata: added
- (*System).RawList: added
- (*System).RawListPath: added

Incompatible changes:
- NewPoliciesListResponseWithDefaults: removed
- PoliciesListResponse: removed
Compatible changes:
- KvV1ListResponse: added
- KvV2ListMetadataResponse: added
- NewKvV1ListResponseWithDefaults: added
- NewKvV2ListMetadataResponseWithDefaults: added
- NewRawListPathResponseWithDefaults: added
- NewRawListResponseWithDefaults: added
- RawListPathResponse: added
- RawListResponse: added
```
@maxb
Copy link
Contributor Author

maxb commented Jul 13, 2023

Closing preview; will open real PRs

@maxb maxb closed this Jul 13, 2023
@maxb maxb deleted the preview-21723 branch July 13, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant