Changes User-Agent header generation #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
reviewed
Apr 4, 2022
| @@ -240,5 +242,11 @@ func getAzureSettings(config *azureConfig) (*azureSettings, error) { | |||
| } | |||
| } | |||
|
|
|||
| pluginEnv, err := b.System().PluginEnv(ctx) | |||
| if err != nil { | |||
| return nil, fmt.Errorf("error loading plugin environment: %w", err) | |||
There was a problem hiding this comment.
Would we consider logging the error instead of failing here? Or is the plugin env info important enough to warrant a failure?
fairclothjm
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR changes User-Agent header generation to rely on the result of
PluginEnv(). This will allow the plugin to correctly determine version information when running as builtin or external to Vault. Currently, the version information may not be correct if running as an external plugin.Additionally, this fixes usage attribution to include the missing
pid-prefix per Azure documentation.Testing
I've verified that the result of
PluginEnv()is correct using Vault oss and enterprise. If VersionMetadata is not empty, we can assume the build is enterprise.See the version format from various Vault builds:
Additional testing will be done to ensure that the GUIDs work as expected for attribution.