Support VMSS Flex Authentications #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Thanks for opening this PR, @zmyzheng. I've left some initial feedback and questions.
…t return principleID
austingebauer
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
LGTM. Thanks again for this contribution, @zmyzheng.
I'm happy to contribute the Vault documentation for this if you haven't started on it already. Let me know.
Thanks @austingebauer so much for reviewing the PR. It will be great if you can update the Vault document. |
|
@zmyzheng - Happy to help. I will update the Vault documentation 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Support VMSS Flex Authentications
Design of Change
How was this change implemented?
When using VMSS Flex with user assigned identity, the service principle Id cannot be dirrectly retrieved from Get-VMSS call. In this PR, we get the user assigned managed identity id and use MSI client to retrieve the service principle info. This change can be applied to both VMSS Uniform and VMSS Flex
Related Issues/Pull Requests
Fix Issue #62
Contributor Checklist
[-] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR Link
Example
[-] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[-] Backwards compatible