Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport #114 release/vault-1.8.x #117

Merged
merged 1 commit into from
Sep 30, 2021
Merged

backport #114 release/vault-1.8.x #117

merged 1 commit into from
Sep 30, 2021
+341 −215

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Sep 29, 2021

This PR is backports #114 . The AliasNameSource feature has been removed since it is only a vault-1.9 targeted feature.

@benashz
fix: validate JWT token on alias look ahead (#114)
80ca628 
- in order to ensure proper validation for alias look ahead the provided
 JWT token must match the role's configuration.

- partial backport dependencies include:
  79c7586
  21abc8d
@benashz benashz changed the title backport #114 backport #114 release/vault-1.8.x Sep 29, 2021
@calvn
Copy link
Member

calvn commented Sep 29, 2021

I'm a bit confused by the size of the diff on this PR compared to #114. Does a git cherry-pick 838df50ef70b58f35fc811b898645bf6d7c65a28 against the release branch work, or did it result in these many changes?

@benashz
Copy link
Contributor Author

benashz commented Sep 29, 2021

I'm a bit confused by the size of the diff on this PR compared to #114. Does a git cherry-pick 838df50ef70b58f35fc811b898645bf6d7c65a28 against the release branch work, or did it result in these many changes?

Yeah it grew a bit unfortunately. Basically 838df50 depended on changes from 79c7586 21abc8d.

@benashz benashz merged commit f5e792a into release/vault-1.8.x Sep 30, 2021
benashz added a commit that referenced this pull request Sep 30, 2021
@benashz
fix: validate JWT token on alias look ahead (#114) (#117)
bb72092 
- in order to ensure proper validation for alias look ahead the provided
 JWT token must match the role's configuration.
- update expired JWT test data

- partial backport dependencies include:
  79c7586
  21abc8d
@benashz benashz deleted the backport-pr-114-1.8.x branch September 30, 2021 22:34
benashz added a commit that referenced this pull request Oct 1, 2021
@benashz
fix: validate JWT token on alias look ahead (#114) (#117)
498c8d8 
- in order to ensure proper validation for alias look ahead the provided
  JWT token must match the role's configuration.
- update expired JWT test data

- partial backport dependencies include:
  79c7586
  21abc8d
benashz added a commit that referenced this pull request Oct 1, 2021
@benashz
fix: validate JWT token on alias look ahead (#114) (#117)
d10269c 
- in order to ensure proper validation for alias look ahead the provided
  JWT token must match the role's configuration.
- update expired JWT test data

- partial backport dependencies include:
  79c7586
  21abc8d
benashz added a commit that referenced this pull request Oct 1, 2021
@benashz
fix: validate JWT token on alias look ahead (#114) (#117) (#119)
951af18 
- in order to ensure proper validation for alias look ahead the provided
  JWT token must match the role's configuration.

- partial backport dependencies include:
  79c7586
  21abc8d
benashz added a commit that referenced this pull request Oct 1, 2021
@benashz
fix: validate JWT token on alias look ahead (#114) (#117) (#120)
a16fac6 
- in order to ensure proper validation for alias look ahead the provided
  JWT token must match the role's configuration.
- update expired JWT test data

- partial backport dependencies include:
  79c7586
  21abc8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvn calvn calvn approved these changes

@tvoran tvoran Awaiting requested review from tvoran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benashz @calvn