Deprecate token issuer validation #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- default disable_iss_validation to true - deprecate disable_iss_validation, and issuer fields.
tvoran
approved these changes
Oct 28, 2021
tomhjp
approved these changes
Oct 28, 2021
benashz
added a commit
that referenced
this pull request
Oct 28, 2021
- default disable_iss_validation to true - deprecate disable_iss_validation, and issuer fields.
Merged
benashz
added a commit
that referenced
this pull request
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In Kubernetes 1.21+, the default issuer varies depending on the service account token type, and since the token review API is the authority there is no need to pre-validate the token issuer. In addition token issuer validation may cause disruptions during a Kubernetes upgrade e.g. 1.20 -> 1.21.
Design of Change
How was this change implemented?
Change the default value for
disable_iss_validationto be true, and deprecate thedisable_iss_validationandissuerconfiguration fields.Related Issues/Pull Requests
[ ] #125
Contributor Checklist
[ ] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR Link
Example
[ ] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[X] Backwards compatible