support for db schedule-based static role rotations #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swenson
reviewed
Sep 21, 2023
| @@ -104,6 +104,11 @@ type VaultStaticCredsMetaData struct { | |||
| // "time to live". This value is compared to the LastVaultRotation to | |||
| // determine if a password needs to be rotated | |||
| RotationPeriod int64 `json:"rotationPeriod"` | |||
| // RotationSchedule is a "chron style" string representing the allowed | |||
There was a problem hiding this comment.
Suggested change
| // RotationSchedule is a "chron style" string representing the allowed | |
| // RotationSchedule is a "cron style" string representing the allowed |
| @@ -226,13 +226,19 @@ spec: | |||
| be rotated | |||
| format: int64 | |||
| type: integer | |||
| rotationSchedule: | |||
| description: RotationSchedule is a "chron style" string representing | |||
There was a problem hiding this comment.
Suggested change
| description: RotationSchedule is a "chron style" string representing | |
| description: RotationSchedule is a "cron style" string representing |
| @@ -226,13 +226,19 @@ spec: | |||
| be rotated | |||
| format: int64 | |||
| type: integer | |||
| rotationSchedule: | |||
| description: RotationSchedule is a "chron style" string representing | |||
There was a problem hiding this comment.
Suggested change
| description: RotationSchedule is a "chron style" string representing | |
| description: RotationSchedule is a "cron style" string representing |
| @@ -543,6 +543,7 @@ _Appears in:_ | |||
| | --- | --- | | |||
| | `lastVaultRotation` _integer_ | LastVaultRotation represents the last time Vault rotated the password | | |||
| | `rotationPeriod` _integer_ | RotationPeriod is number in seconds between each rotation, effectively a "time to live". This value is compared to the LastVaultRotation to determine if a password needs to be rotated | | |||
| | `rotationSchedule` _string_ | RotationSchedule is a "chron style" string representing the allowed schedule for each rotation. e.g. "1 0 * * *" would rotate at one minute past midnight (00:01) every day. | | |||
There was a problem hiding this comment.
Suggested change
| | `rotationSchedule` _string_ | RotationSchedule is a "chron style" string representing the allowed schedule for each rotation. e.g. "1 0 * * *" would rotate at one minute past midnight (00:01) every day. | | |
| | `rotationSchedule` _string_ | RotationSchedule is a "cron style" string representing the allowed schedule for each rotation. e.g. "1 0 * * *" would rotate at one minute past midnight (00:01) every day. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the upcoming 1.15 Vault feature
Related docs PR for the feature