Update code owners and GH actions #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevendpclark
commented
May 10, 2024
stevendpclark
commented
- Update the code owners file as the cryptosec team apparently owns this now
- Swap the Jira sync workflow to use the hashicorp/vault-workflows-common workflow to get rid of node 16 deprecation warnings
- Update the workflows using the deprecated set-output command to the new environment style based on https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
- Update pinned actions to the latest supported by the TSCCR tool.
- Update the various workflows to get rid of the set-output commands and use the new way using environment files based on the following blog post. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
stevendpclark
commented
May 10, 2024
| @@ -1 +1 @@ | |||
| # release configuration | |||
| * @hashicorp/vault-crypto | |||
There was a problem hiding this comment.
Working with Luciano on getting the vault-crypto group write access to the repo.
tvoran
approved these changes
May 10, 2024
.github/workflows/build.yml
Outdated
|
|
||
| - name: Setup go | ||
| uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0 | ||
| uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1 | ||
| with: | ||
| go-version: ${{ needs.get-go-version.outputs.go-version }} |
There was a problem hiding this comment.
I'd suggest removing the get-go-version job and just use .go-version here, since setup-go supports that now.
Suggested change
| go-version: ${{ needs.get-go-version.outputs.go-version }} | |
| go-version-file: .go-version |
There was a problem hiding this comment.
TIL: I thought you could only specify go.mod/go.work files but looking at the source it does seem to accept other files with just the Go version.
There was a problem hiding this comment.
Addressed in ffda033
- Eliminate the job step to get the Go version manually and leverage setup-go's argument to read it from a repository file instead.
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.