Fix HelpOperation on sudo-protected paths (#18568)

* Fix HelpOperation on sudo-protected paths Fixes #18566 * Add changelog
hashicorp · Jan 10, 2023 · 4758cc8 · 4758cc8
1 parent 1fca38a
commit 4758cc8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/changelog/18568.txt b/changelog/18568.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+core: Fix spurious `permission denied` for all HelpOperations on sudo-protected paths
+```
diff --git a/vault/acl.go b/vault/acl.go
@@ -719,7 +719,9 @@ func (c *Core) performPolicyChecks(ctx context.Context, acl *ACL, te *logical.To
 		if !ret.ACLResults.Allowed {
 			return ret
 		}
-		if !ret.RootPrivs && opts.RootPrivsRequired {
+		// Since HelpOperation was fast-pathed inside AllowOperation, RootPrivs will not have been populated in this
+		// case, so we need to special-case that here as well, or we'll block HelpOperation on all sudo-protected paths.
+		if !ret.RootPrivs && opts.RootPrivsRequired && req.Operation != logical.HelpOperation {
 			return ret
 		}
 	}