Skip to content

Commit

Permalink
Replication Primary Dashboard: handle errors (#8845)
Browse files Browse the repository at this point in the history
* use h3 instead of code elements

* use correct property names for StateDisplay

* WIP

* remove todo

* move cluster states into a map; make status menu icon match cluster state

* show error in state card using the same state map in the cluster model

* whitespace

* move cluster-states into a helper and update usage

* use circle success icon for stream-wals because that is the ideal state

* more refactoring of cluster state display

* use new cluster-states helper

* whitespace

* use clusterStates helper in replication secondary card

* remove extra import

* add default values for when state isn't recognized

* make sure that state exists before getting state details from clusterStates helper

* be more strict when state cannot be found

* use brace expansion to fix linting error

* add tests for error states

* fix text wrapping issue on secondary cards; make titles match mocks

* use unknown if metric isn't foudn

* remove extra border on selectable card when there is an error

* use outline square in status menu for error
  • Loading branch information
Noelle Daley authored and Monkeychip committed Apr 30, 2020
1 parent c5ce3a2 commit 9f830b1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion ui/lib/core/addon/components/replication-dashboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ export default Component.extend({
data: null,
replicationDetails: null,
isSecondary: null,
dr: null,
isSyncing: computed('replicationDetails', 'isSecondary', function() {
const { state } = this.replicationDetails;
const isSecondary = this.isSecondary;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { CLUSTER_STATES } from 'core/helpers/cluster-states';
import hbs from 'htmlbars-inline-precompile';
const resolver = engineResolverFor('replication');

module('Integration | Component | replication-primary-card', function(hooks) {
module('Integration | Enterprise | Component | replication-primary-card', function(hooks) {
setupRenderingTest(hooks, { resolver });

test('it renders', async function(assert) {
Expand Down

0 comments on commit 9f830b1

Please sign in to comment.