fix by returning apiPath from the model #10122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelshaw
approved these changes
Oct 19, 2020
| @@ -23,6 +23,7 @@ export function sanitizePath(path) { | |||
|
|
|||
| export default Service.extend({ | |||
| attrs: null, | |||
| dynamicApiPath: '', | |||
There was a problem hiding this comment.
We don't need this set here if it's just being passed into urlForItem right?
There was a problem hiding this comment.
When writing a test, I noticed that it needs to be set as an empty string because it will hit getDynamicApiPath before result.apiPath is set. It then hits it again when it is set.
ui/app/services/path-help.js
Outdated
|
|
||
| // the apiPath changes when you switch between routes but the apiPath variable does not unless the model is reloaded | ||
| // check first for the dynamicApiPath which is passed through from the model->adapter | ||
| // If no dynamicApiPath, then use apiPath set higher up in function |
There was a problem hiding this comment.
nit: I find the wording here a bit confusing. It's not exactly checking for dynamicApiPath "first", it's just overwriting apiPath if the value exists
| @@ -0,0 +1,59 @@ | |||
| import { click, fillIn, settled, visit } from '@ember/test-helpers'; | |||
Monkeychip
added a commit
that referenced
this pull request
Oct 19, 2020
* fix by returning apiPath from the model * remove unused service * be more specific of when setting dynamicApiPath * new acceptance test for auth list * remove unused policy * udpate comment
Monkeychip
added a commit
that referenced
this pull request
Oct 19, 2020
* fix by returning apiPath from the model * remove unused service * be more specific of when setting dynamicApiPath * new acceptance test for auth list * remove unused policy * udpate comment
Monkeychip
added a commit
that referenced
this pull request
Oct 19, 2020
Monkeychip
added a commit
that referenced
this pull request
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where on route change the model is not refreshed and therefore the path to the auth method for listing roles was not being called properly. Originally this was reported in an Asana ticket for Kubernetes, but it's an issue with all auth methods.
The fix was to use the store to return the
generated-item-listadapter that is then passed to thepath-helpservice.Below you can see the change. Where before you'd see the same role list from the previous auth method selected. It would only change on refresh which would cause the model to refresh.
Additionally, when I was writing a test I noticed that in certain cases if you transitioned between auth methods and created a role or user you would create that user at the endpoint of the previous route you had visited. Here's a video of that happening. The test I wrote checks both for this and the original fix. This can still happen if you copy/paste to the create link, but that does not follow the regular flow of a UI user. However, I thought it was worthing pointing out. It has something to do with how the path is first created and not refreshed, but I was unable to get to the meat of the problem.