Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/managed namespace changes #10588

Merged
merged 21 commits into from
Jan 7, 2021
Merged

UI/managed namespace changes #10588

merged 21 commits into from
Jan 7, 2021

Conversation

chelshaw
Copy link
Contributor

@chelshaw chelshaw commented Dec 16, 2020

These changes include:

  • un-editable namespace prefix on auth route, if managed
  • redirect to base namespace (for logged in user) or managed namespace root if no namespace param is present
  • Tests

When a root namespace is retrieved from endpoint and no namespace param is present, redirect:
rootNamespaceRedirect

Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work so far!

@@ -0,0 +1,9 @@
import Service from '@ember/service';

export default Service.extend({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With octane you should be able to start writing these as Native classes (however, ignore me if we have to backport to prior to 1.7).
ex:

import Service from '@ember/service';

export default class ShoppingCartService extends Service {
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, however we do indeed have to backport this to prior to 1.7 😭

@chelshaw chelshaw marked this pull request as ready for review January 5, 2021 16:51
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

ui/mirage/config.js Outdated Show resolved Hide resolved
@chelshaw chelshaw merged commit 54239ba into master Jan 7, 2021
@chelshaw chelshaw deleted the ui/hcp-namespace-changes branch January 7, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants