Fix quota enforcing old path issue #10689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnayak
commented
Jan 13, 2021
mgritter
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
This looks good, but don't we need to do the same thing for lease count quotas, to catch changes to namespace and path?
switch {
case quota == nil:
quota = quotas.NewLeaseCountQuota(name, ns.Path, mountPath, int64(maxLeases))
default:
lcq := quota.(*quotas.LeaseCountQuota)
lcq.NamespacePath = ns.Path
lcq.MountPath = mountPath
lcq.MaxLeases = int64(maxLeases)
}
|
Yep. We need to. That PR will follow. |
vishalnayak
added a commit
that referenced
this pull request
Feb 9, 2021
* Fix db indexing issue * Add CL update
vishalnayak
added a commit
that referenced
this pull request
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.