Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/expiration: Switch Expiration Manager to use Fairsharing Backpressure #10932

Merged
merged 1 commit into from
Feb 17, 2021

Commits on Feb 17, 2021

  1. Vault-1403 Switch Expiration Manager to use Fairsharing Backpressure (#…

    …1709)
    
    * basic pool and start testing
    
    * refactor a bit for testing
    
    * workFunc, start/stop safety, testing
    
    * cleanup function for worker quit, more tests
    
    * redo public/private members
    
    * improve tests, export types, switch uuid package
    
    * fix loop capture bug, cleanup
    
    * cleanup tests
    
    * update worker pool file name, other improvements
    
    * add job manager prototype
    
    * remove remnants
    
    * add functions to wait for job manager and worker pool to stop, other fixes
    
    * test job manager functionality, fix bugs
    
    * encapsulate how jobs are distributed to workers
    
    * make worker job channel read only
    
    * add job interface, more testing, fixes
    
    * set name for dispatcher
    
    * fix test races
    
    * wire up expiration manager most of the way
    
    * dispatcher and job manager constructors don't return errors
    
    * logger now dependency injected
    
    * make some members private, test fcn to get worker pool size
    
    * make GetNumWorkers public
    
    * Update helper/fairshare/jobmanager_test.go
    
    Co-authored-by: Brian Kassouf <briankassouf@users.noreply.github.com>
    
    * update fairsharing usage, add tests
    
    * make workerpool private
    
    * remove custom worker names
    
    * concurrency improvements
    
    * remove worker pool cleanup function
    
    * remove cleanup func from job manager, remove non blocking stop from fairshare
    
    * update job manager for new constructor
    
    * stop job manager when expiration manager stopped
    
    * unset env var after test
    
    * stop fairshare when started in tests
    
    * stop leaking job manager goroutine
    
    * prototype channel for waking up to assign work
    
    * fix typo/bug and add tests
    
    * improve job manager wake up, fix test typo
    
    * put channel drain back
    
    * better start/pause test for job manager
    
    * comment cleanup
    
    * degrade possible noisy log
    
    * remove closure, clean up context
    
    * improve revocation context timer
    
    * test: reduce number of revocation workers during many tests
    
    * Update vault/expiration.go
    
    Co-authored-by: Brian Kassouf <briankassouf@users.noreply.github.com>
    
    * feedback tweaks
    
    Co-authored-by: Brian Kassouf <briankassouf@users.noreply.github.com>
    swayne275 and briankassouf committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    df11749 View commit details
    Browse the repository at this point in the history