Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secrets/mongodbatlas: Backport whitelist to accesslist #10966

Merged
merged 5 commits into from
Feb 22, 2021
Merged

secrets/mongodbatlas: Backport whitelist to accesslist #10966

merged 5 commits into from
Feb 22, 2021

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Feb 22, 2021 •
edited
Loading

@vercel
Copy link

vercel bot commented Feb 22, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

vault – ./website

🔍 Inspect: https://vercel.com/hashicorp/vault/CABwKp1oWYiYW2iDaPXdXyDGApsX
✅ Preview: Canceled

[Deployment for 210244b canceled]

vault-storybook – ./ui

🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/7Cye3qBnqogZ7vhfa2fRQFYE8zWc
✅ Preview: https://vault-storybook-git-backport-whitelist-to-accesslist-hashicorp.vercel.app

@tomhjp tomhjp mentioned this pull request Feb 22, 2021
Merged
@tomhjp tomhjp added this to the 1.6.3 milestone Feb 22, 2021
@tomhjp tomhjp changed the title Backport whitelist to accesslist secrets/mongodbatlas: Backport whitelist to accesslist Feb 22, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 22, 2021 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – vault February 22, 2021 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – vault February 22, 2021 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 22, 2021 15:05 Inactive
Valarissa
Valarissa approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@Valarissa Valarissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasonodonnell
jasonodonnell approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, race detection seems unrelated but would be good to verify.

@tomhjp
Copy link
Contributor Author

tomhjp commented Feb 22, 2021

race detection seems unrelated but would be good to verify.

Yup, the race failures are in TestActivityLog and have happened on previous commits in the branch too.

@vercel vercel bot temporarily deployed to Preview – vault February 22, 2021 17:30 Inactive
@tomhjp tomhjp merged commit f987079 into release/1.6.x Feb 22, 2021
@tomhjp tomhjp deleted the backport-whitelist-to-accesslist branch February 22, 2021 17:48
@kopiczko kopiczko mentioned this pull request Mar 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valarissa Valarissa Valarissa approved these changes

@jasonodonnell jasonodonnell jasonodonnell approved these changes

@calvn calvn Awaiting requested review from calvn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@tomhjp @Valarissa @jasonodonnell