Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add null check before getting userRootNamespace from storage #11094

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

chelshaw
Copy link
Contributor

@chelshaw chelshaw commented Mar 11, 2021

This fixes an issue where if you log in without anything in the "namespace" input, there is a failure on the page:
Screen Shot 2021-03-10 at 18 58 59

Note: this should not affect OSS

@chelshaw chelshaw added ui backport bug Used to indicate a potential bug labels Mar 11, 2021
@vercel vercel bot temporarily deployed to Preview – vault March 11, 2021 18:51 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 11, 2021 18:51 Inactive
@chelshaw chelshaw merged commit de45ff6 into master Mar 11, 2021
@chelshaw chelshaw deleted the ui/fix-no-namespace-login branch March 11, 2021 19:09
chelshaw added a commit that referenced this pull request Mar 11, 2021
)

* Add null check before getting userRootNamespace from storage

* Add changelog
chelshaw added a commit that referenced this pull request Mar 11, 2021
) (#11095)

* Add null check before getting userRootNamespace from storage

* Add changelog
arnav28 pushed a commit that referenced this pull request May 17, 2021
)

* Add null check before getting userRootNamespace from storage

* Add changelog
arnav28 added a commit that referenced this pull request May 17, 2021
) (#11635)

* Add null check before getting userRootNamespace from storage

* Add changelog

Co-authored-by: Chelsea Shaw <chelshaw.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants