Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/obscure secret on input #11284

Merged
merged 39 commits into from
Apr 22, 2021
Merged

UI/obscure secret on input #11284

merged 39 commits into from
Apr 22, 2021

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented Apr 6, 2021

This PR is a project to Obscure Secret Values on input, and to also obscure certificates on display. There is an option in both of these to toggle on/off the obscured view. To accomplish this, design created a new font called "obscure.woff". We now default to using this font on any input or text-area for either masked-input components and text-file components.

The following are screenshots of places were secrets are now obscured by default:

  • Shamir keys

  • Anytime we display a secret value, via masked-input @displayOnly=true

  • Generate credentials (database secret engine example)

  • KV Secret engine Copy -> Generate wrap

  • No longer displaying certificates on default, but masking them and truncating the output. The user can then opt to see the certificate.

Notes:

  • I was able to glimmerize/update the text-file component, but I was not able to glimmerize the masked-input component. I suspect the latter is because of the use of a partial in the component chain.
  • For the pgp-file.hbs component, eventually, we will want to replace this with the text-file component. See start of code here. However, it would require some additional refactoring and be beyond the scope of this project. Currently, this is the only area in the application where you find the upload file but do not see the option to mask/unmask when entering as text.

@Monkeychip Monkeychip added the ui label Apr 6, 2021
@Monkeychip Monkeychip added this to the 1.8 milestone Apr 6, 2021
@Monkeychip Monkeychip marked this pull request as ready for review April 16, 2021 16:35
Copy link
Collaborator

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! A couple small updates, and I'm going to pull down the branch and try to break it 😁

ui/app/components/text-file.js Show resolved Hide resolved
ui/app/styles/components/masked-input.scss Outdated Show resolved Hide resolved
ui/app/styles/core/forms.scss Show resolved Hide resolved
ui/app/templates/components/config-pki-ca.hbs Outdated Show resolved Hide resolved
ui/lib/core/addon/helpers/date-format.js Show resolved Hide resolved
Copy link
Collaborator

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for making these changes

@Monkeychip Monkeychip merged commit bcdff2e into master Apr 22, 2021
@Monkeychip Monkeychip deleted the ui/obscure-secret-on-input branch April 22, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants