Fix goroutine leak caused by updating rate quotas #11371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utine before starting the new one.
ncabatoff
changed the title
vishalnayak
approved these changes
Apr 16, 2021
ncabatoff
added a commit
that referenced
this pull request
Apr 16, 2021
Make sure that when we modify a rate quota, we stop the existing goroutine before starting the new one.
ncabatoff
added a commit
that referenced
this pull request
Apr 16, 2021
Make sure that when we modify a rate quota, we stop the existing goroutine before starting the new one.
ncabatoff
added a commit
that referenced
this pull request
Apr 16, 2021
ncabatoff
added a commit
that referenced
this pull request
Apr 16, 2021
…) (#11380) Make sure that when we modify a rate quota, we stop the existing goroutine before starting the new one.
| sink, _ := metrics.New(metrics.DefaultConfig(""), | ||
| &metrics.BlackholeSink{}) | ||
| conf := metrics.DefaultConfig("") | ||
| conf.EnableRuntimeMetrics = false |
There was a problem hiding this comment.
Was this intentionally disabled?
There was a problem hiding this comment.
Yes, to avoid it creating a goroutine that interferes with the leak test. I believe BlackholeSink is only used in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.