UI/update deps 1.8 #11447
UI/update deps 1.8 #11447
Conversation
…-inline-precompile addon dep
|
Vercel vault-storybook deployment failure is due to an issue I saw locally and solved my removing |
| @@ -301,6 +302,7 @@ export default Route.extend(UnloadModelRoute, { | |||
| }, | |||
|
|
|||
| willTransition(transition) { | |||
| /* eslint-disable-next-line ember/no-controller-access-in-routes */ | |||
There was a problem hiding this comment.
gosh we use controllerFor in loads of places. Do you know when this will be officially depreciated?
There was a problem hiding this comment.
That's a good question, I don't know if it's a disallow thing or a best practice thing 🤔 Cursory search did not bring up any answers but maybe we should ask in the front end sync
ui/package.json
Outdated
| @@ -183,7 +183,7 @@ | |||
| "node": "10.* || >= 12" | |||
| }, | |||
| "ember": { | |||
| "edition": "octane" | |||
| "edition": "recommended" | |||
There was a problem hiding this comment.
that's interesting. do you know why this had to change?
There was a problem hiding this comment.
Oh good catch, I changed this when I was wrestling with linting changes. I'll change it back and make sure linting is still good 👍
| @@ -146,6 +146,7 @@ module('Acceptance | Enterprise | control groups', function(hooks) { | |||
| await visit(url); | |||
| await settled(); | |||
| accessor = controlGroupComponent.accessor; | |||
| console.log({ accessor }); | |||
There was a problem hiding this comment.
looks like left over console.log?
| "ember-cli-inject-live-reload": "^2.0.2", | ||
| "ember-cli-mirage": "^1.1.8", | ||
| "ember-cli-page-object": "^1.17.0", | ||
| "ember-cli-pretender": "^3.1.1", |
There was a problem hiding this comment.
nice! Finally we'll stop seeing those warning messages on build
Upgrade ember to latest LTS version (3.22) as well as update a number of dependencies