Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAULT-1441] Fix race that allowed remounting on path used by another mount #11453

Merged
merged 3 commits into from
Apr 24, 2021
Merged

[VAULT-1441] Fix race that allowed remounting on path used by another mount #11453

merged 3 commits into from
Apr 24, 2021

Conversation

HridoyRoy
Copy link
Contributor

No description provided.

@swayne275
Copy link
Contributor

tests run on yours but not mine! jealous

@ncabatoff
Copy link
Collaborator

Please add a changelog entry.

@HridoyRoy
Copy link
Contributor Author

Please add a changelog entry.

Done!

@ncabatoff ncabatoff changed the title [VAULT-1441] Allow Concurrent Remounts [VAULT-1441] Fix race that allowed remounting on same path Apr 23, 2021
@ncabatoff ncabatoff changed the title [VAULT-1441] Fix race that allowed remounting on same path [VAULT-1441] Fix race that allowed remounting on path used by another mount Apr 23, 2021
ncabatoff
ncabatoff reviewed Apr 23, 2021
View reviewed changes
changelog/11453.txt Outdated Show resolved Hide resolved
ncabatoff
ncabatoff approved these changes Apr 23, 2021
View reviewed changes
Copy link
Collaborator

@ncabatoff ncabatoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, added suggestion for more meaningful CL

@ncabatoff
Update changelog/11453.txt
17754c1 
Co-authored-by: Nick Cabatoff <ncabatoff@hashicorp.com>
@vercel vercel bot temporarily deployed to Preview – vault April 23, 2021 18:22 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 23, 2021 18:22 Inactive
@HridoyRoy HridoyRoy merged commit efd19a2 into master Apr 24, 2021
@HridoyRoy HridoyRoy deleted the vault-1441 branch April 24, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncabatoff ncabatoff ncabatoff approved these changes

@swayne275 swayne275 swayne275 approved these changes

@briankassouf briankassouf Awaiting requested review from briankassouf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HridoyRoy @swayne275 @ncabatoff