Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct mount accessor when refreshing external group memberships #11506

Merged
merged 3 commits into from
May 3, 2021
Merged

Use correct mount accessor when refreshing external group memberships #11506

merged 3 commits into from
May 3, 2021

Conversation

vishalnayak
Copy link
Member

@vishalnayak vishalnayak commented Apr 30, 2021 •
edited
Loading

Fixes #11487

@vishalnayak vishalnayak requested review from sgmiller and a team April 30, 2021 18:09
@vishalnayak vishalnayak added this to the 1.7.2 milestone Apr 30, 2021
sgmiller
sgmiller approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@sgmiller sgmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vercel vercel bot temporarily deployed to Preview – vault April 30, 2021 19:17 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 30, 2021 19:17 Inactive
@vishalnayak
Copy link
Member Author

This PR is a follow up of #11488 submitted by @ianferguson. Added a test and made a minor change to the fix.

@sgmiller sgmiller mentioned this pull request Apr 30, 2021
Closed
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 30, 2021 21:00 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 30, 2021 21:00 Inactive
ianferguson
ianferguson approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@ianferguson ianferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you so much!

@vishalnayak vishalnayak merged commit a251a12 into master May 3, 2021
@vishalnayak vishalnayak deleted the external-identity-groups branch May 3, 2021 12:24
vishalnayak added a commit that referenced this pull request May 3, 2021
@vishalnayak
Use correct mount accessor when refreshing external group memberships (…
8cab883 
…#11506)

* Use correct mount accessor when refreshing external group memberships

* Add CL

* Handle the renew case properly
@vishalnayak vishalnayak mentioned this pull request May 3, 2021
Merged
vishalnayak added a commit that referenced this pull request May 3, 2021
@vishalnayak
Use correct mount accessor when refreshing external group memberships (…
55a61c7 
…#11506) (#11516)

* Use correct mount accessor when refreshing external group memberships

* Add CL

* Handle the renew case properly
@sgmiller sgmiller mentioned this pull request May 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianferguson ianferguson ianferguson approved these changes

@sgmiller sgmiller sgmiller approved these changes

@briankassouf briankassouf briankassouf approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
1.7.2
Development

Successfully merging this pull request may close these issues.

External Group memberships incorrectly deleted when using multiple auth mounts
4 participants
@vishalnayak @ianferguson @sgmiller @briankassouf