UI unseal screen updates #11705
Merged
UI unseal screen updates #11705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
approved these changes
May 26, 2021
arnav28
reviewed
May 26, 2021
| @@ -19,5 +20,9 @@ export default Controller.extend({ | |||
| isUnsealed(data) { | |||
| return data.sealed === false; | |||
| }, | |||
|
|
|||
| handleLicenseError() { | |||
| this.set('showLicenseError', true); | |||
There was a problem hiding this comment.
Can we still use this.set?
There was a problem hiding this comment.
Yes, possibly because this is in a controller? I considered moving all of this logic to a separate component that we can glimmerize but that seemed out of scope for this, especially considering the backport
arnav28
approved these changes
May 26, 2021
hashishaw
added a commit
that referenced
this pull request
May 26, 2021
* Styling for empty-state and splash-page * Update shamir-flow language and trigger onError on non-400 error * Add license terminated screen to unseal * Add changelog
hashishaw
added a commit
that referenced
this pull request
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the style and language on the Vault unseal screen, and adds a specific view when a login attempt fails with the error
licensing is in an invalid state. There are now links to relevant documentation on both the unseal form and the license error view.As you can see from the gif below, it still shows other errors correctly on the unseal form itself, and then disallows the ability to try to unseal once a licensing error is detected: