Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/cp validations kv duplicate path #11878

Merged
merged 11 commits into from
Jun 22, 2021
Merged

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented Jun 16, 2021

This is the last validation piece for the KV secret engine.

duplicate-paths

The reason Design wanted to include this validation error is because of the Require check and set option, which is on by default in the UI. If you name the path the same, we currently show the following API error, which is not very helpful. So instead of hitting this API error, we are instead returning a validation error that's more clear.

image

Notes:

  • I did not include a changelog because it's covered under the previous changelog "adding validation to the kv secret engine"
  • I did not include this in the last PR because I wanted to get that through so I would unblock another team member.
  • I could have used peekRecord however it would not have checked the multiple pages of path names nor would it return values if you cold refreshed from the create secret page. You had to have navigated from the list of paths page first.

@Monkeychip Monkeychip added the ui label Jun 16, 2021
@Monkeychip Monkeychip added this to the 1.8 milestone Jun 16, 2021
Copy link
Collaborator

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@vercel vercel bot temporarily deployed to Preview – vault June 21, 2021 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook June 21, 2021 20:52 Inactive
@Monkeychip Monkeychip merged commit 8ed98f4 into main Jun 22, 2021
@Monkeychip Monkeychip deleted the ui/cp-validations-kv-duplicate-path branch June 22, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants