UI/fix safari oidc login #11884
Merged
UI/fix safari oidc login #11884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashishaw
commented
Jun 17, 2021
| }); | ||
|
|
||
| test('oidc: storage event fires with state key, wrong params', async function(assert) { |
There was a problem hiding this comment.
Removed this test because we don't fire en event
Monkeychip
reviewed
Jun 17, 2021
hashishaw
commented
Jun 17, 2021
| @@ -55,7 +55,7 @@ | |||
| @roleName={{this.roleName}} | |||
| @selectedAuthType={{this.selectedAuthBackend.type}} | |||
| @selectedAuthPath={{or this.customPath this.selectedAuthBackend.id}} | |||
| @disabled={{authenticate.isRunning}} | |||
| @disabled={{or authenticate.isRunning this.isLoading}} | |||
There was a problem hiding this comment.
Added this because once the popup is closed, while things are processing but before authenticate runs, the button is clickable again and it was confusing
Monkeychip
reviewed
Jun 17, 2021
Monkeychip
approved these changes
Jun 17, 2021
hashishaw
added a commit
that referenced
this pull request
Jun 18, 2021
* use window.postMessage instead of localStorage on oidc callback
hashishaw
added a commit
that referenced
this pull request
Jun 21, 2021
* use window.postMessage instead of localStorage on oidc callback
This was referenced Jun 21, 2021
hashishaw
added a commit
that referenced
this pull request
Jun 22, 2021
hashishaw
added a commit
that referenced
this pull request
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a Safari localStorage bug, logging into Vault with OIDC was not working because the login tab never saw the
localStoragewrite from the popup tab. To resolve, we are replacinglocalStoragein this scenario with a postMessage call between the two tabs.Before:
After:
