-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identity: prepublish jwt signing keys #12414
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3bdd22a
pre-publish new signing keys for `rotation_period` of time before using
ianferguson 36c6b2b
Work In Progress: Prepublish JWKS and even cache control
ianferguson 333046b
remove comments
fairclothjm 1f0a386
use math/rand instead of math/big
fairclothjm 0b2549d
update tests
fairclothjm 45077ce
remove debug comment
fairclothjm 7845184
resolve merge conflict
fairclothjm 8a24df4
refactor cache control logic into func
fairclothjm d12cb04
don't set expiry when create/update key
fairclothjm 7fa6beb
update cachecontrol name in oidccache for test
fairclothjm 7e3d250
fix bug in periodicfunc test case
fairclothjm c9fef0d
add changelog
fairclothjm 9cadd12
remove confusing comment
fairclothjm a39d7df
add logging and comments
fairclothjm f86b83c
update change log from bug to improvement
fairclothjm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:bug | ||
identity: fix issue where Cache-Control header causes stampede of requests for JWKS keys | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I wonder if this is an enhancement instead of a bug? I think the implementation before functioned as designed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with that