Bug fix: allow forward slash in paths for delete menu #12550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnav28
approved these changes
Sep 14, 2021
Monkeychip
added a commit
that referenced
this pull request
Sep 14, 2021
* fix bug and add test coverage * changelog
Monkeychip
added a commit
that referenced
this pull request
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using
encodeURIComponenton the capabilities checks on the secret-delete-menu. This prevented the proper capabilities checks when you had forward slash or dashes in either the engine name or the pathname.I added test coverage to double check for this in the furture.
This bug was a regression caused by this PR. I'll be backporting to 1.8.