Skip metric increment during existence check #12763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vinayak Kadam <kadamvinayak03@gmail.com>
Signed-off-by: Vinayak Kadam <kadamvinayak03@gmail.com>
ncabatoff
reviewed
Oct 7, 2021
changelog/12763.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note: bug | |||
| COMPONENT: Telemetry data getting counted twice | |||
There was a problem hiding this comment.
Suggested change
| COMPONENT: Telemetry data getting counted twice | |
| core: Fix double counting for "route" metrics |
There was a problem hiding this comment.
Updated changelog text
Signed-off-by: Vinayak Kadam <kadamvinayak03@gmail.com>
ncabatoff
approved these changes
Oct 8, 2021
HridoyRoy
approved these changes
Jan 27, 2022
|
Hi @vinayak03 - CircleCI has been a bit squirrelly as of late, and isn't wanting to report the automated test results to GitHub. Would you be willing to push an empty commit in order to get the tests nudged forward, so we can get this merged? Thanks in advance for your patience! |
|
Hi |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metric are counted twice on single API call because we are calling the same function during existence check as well as update/write phase. This PR is simply adding check as to when we should record the metric.
I tried adding a unit test however since we are directly using the metrics in router, I was not able to add it.
Closes #12060
Signed-off-by: Vinayak Kadam kadamvinayak03@gmail.com