Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Info table row typography #12908

Merged
merged 4 commits into from
Oct 22, 2021
Merged

Info table row typography #12908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
927dc3a
updates info table row value font
zofskeez Oct 22, 2021
3bd98d7
adds changelog
zofskeez Oct 22, 2021
b13b90d
updates tests
zofskeez Oct 22, 2021
dbe6cfd
attempts to fix flaky mount-secret-backend acceptance test
zofskeez Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/12908.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
ui: Updates font for table row value fields
```
4 changes: 2 additions & 2 deletions ui/lib/core/addon/templates/components/info-table-row.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
@horizontalPosition="left"
as |T|>
<T.trigger @tabindex=false>
<code class="is-word-break has-text-black" data-test-row-value="{{label}}">{{value}}</code>
<span class="is-word-break has-text-black" data-test-row-value="{{label}}">{{value}}</span>
</T.trigger>
<T.content @class="tool-tip">
<CopyButton
Expand All @@ -73,7 +73,7 @@
</T.content>
</ToolTip>
{{else}}
<code class="is-word-break has-text-black" data-test-row-value="{{label}}">{{value}}</code>
<span class="is-word-break has-text-black" data-test-row-value="{{label}}">{{value}}</span>
{{/if}}
{{/if}}
{{/if}}
Expand Down
2 changes: 1 addition & 1 deletion ui/tests/acceptance/settings/mount-secret-backend-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ module('Acceptance | settings/mount-secret-backend', function(hooks) {
`write sys/policies/acl/kv-v2-degrade policy=${btoa(V2_POLICY)}`,
'write -field=client_token auth/token/create policies=kv-v2-degrade',
]);

await settled();
let userToken = consoleComponent.lastLogOutput;
await logout.visit();
await authPage.login(userToken);
Expand Down
6 changes: 2 additions & 4 deletions ui/tests/integration/components/info-table-row-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ module('Integration | Component | InfoTableRow', function(hooks) {
/>`);

assert.dom('[data-test-component="info-table-row"]').exists();
let string = document.querySelector('code').textContent;
assert.equal(string, VALUE, 'renders value as passed through');
assert.dom('[data-test-row-value]').hasText(VALUE, 'renders value as passed through');

this.set('value', '');
assert
Expand Down Expand Up @@ -101,8 +100,7 @@ module('Integration | Component | InfoTableRow', function(hooks) {
@label={{label}}
@isLink={{true}}
/>`);
let string = document.querySelector('code').textContent;
assert.equal(string, VALUE, 'renders value in code element and not in a tag');
assert.dom('[data-test-row-value]').hasText(VALUE, 'renders value in code element and not in a tag');
});

test('it renders links if isLink is true and type is array', async function(assert) {
Expand Down