Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/Fixes secrets list breadcrumb #13604

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Jan 8, 2022

Breadcrumbs weren't updating as file tree was navigated. Fixes #13581

Bug
secrets_breadcrumb

With fix

breadcrumb_bug

@hellobontempo
Copy link
Contributor Author

Will add milestone label once backporting is confirmed!

@@ -1,7 +1,7 @@
{{#with (options-for-backend @model.engineType) as |options|}}
<PageHeader as |p|>
<p.top>
<KeyValueHeader @baseKey={{this.baseKey}} @path="vault.cluster.secrets.backend.list" @root={{@backendCrumb}}>
<KeyValueHeader @baseKey={{@baseKey}} @path="vault.cluster.secrets.backend.list" @root={{@backendCrumb}}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, probably a backport to 1.9 because I believe in 1.9 I glimmerized this component and this would be a glimmer issue. Nice catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Monkeychip - from what I could tell this behavior has been happening since before 1.7? But I'll reconfirm next week

@vercel vercel bot temporarily deployed to Preview – vault-storybook January 8, 2022 02:44 Inactive
@vercel vercel bot temporarily deployed to Preview – vault January 8, 2022 02:44 Inactive
@hellobontempo hellobontempo added this to the 1.7.9 milestone Jan 10, 2022
@hellobontempo hellobontempo added bug Used to indicate a potential bug backport/1.8.x labels Jan 10, 2022
@hellobontempo hellobontempo merged commit 900831d into main Jan 10, 2022
@hellobontempo hellobontempo deleted the ui/secrets-breadcrumb-bug branch January 10, 2022 19:35
heppu pushed a commit to heppu/vault that referenced this pull request Jan 13, 2022
* fixes basekey param

* adds changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation bar is missing
2 participants