Add tag to fix DNS bug with mac builds #13728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
reviewed
Jan 20, 2022
If you'll forgive the pedantry: it's not that migrating to github caused the DNS issue, it's rather that the issue is long-standing and now we can finally do something about it. Fixes #12012 |
ncabatoff
approved these changes
Jan 20, 2022
sarahethompson
approved these changes
Jan 20, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per: https://hashicorp.atlassian.net/browse/RDX-205 (which goes into depth about our research on this issue) - this change adds the "netcgo" build tag to mac builds, which addresses a dns issue caused when our builds migrated to github runners.