Transform Advanced Templating #13908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d adds capture groups support
…named capture groups
hashishaw
reviewed
Feb 4, 2022
| @action | ||
| deleteRow(object, index) { | ||
| const oldObj = this.kvData.objectAt(index); | ||
| assert('object guids match', guidFor(oldObj) === guidFor(object)); |
There was a problem hiding this comment.
Do we want to keep this in here?
There was a problem hiding this comment.
I left most of the logic as is when glimmerizing to avoid breaking anything but this doesn't seem useful to me. I think it would be fine to remove as well as the guidFor(newObj) on line 58.
fairclothjm
pushed a commit
that referenced
this pull request
Feb 12, 2022
* updates regex-validator component to optionally show pattern input and adds capture groups support * adds form-field-label component * adds autocomplete-input component * updates kv-object-editor component to yield block for value and glimmerizes * updates transform template model * adds transform-advanced-templating component * updates form-field with child component changes * updates transform template serializer to handle differences in regex named capture groups * fixes regex-validator test * adds changelog entry * updates for pr review feedback * reverts kv-object-editor guidFor removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to define the encode and decode formats of a transform template. To assist the user, a sample input to test the pattern was added that will display the capture groups when there is a match. An autocomplete input component was also created that allows the user to select capture groups when defining encode/decode formats which is triggered when the user inputs the
$character.