Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to secure signing algorithm for SSH secrets engine #14006

Merged
merged 6 commits into from
Feb 18, 2022
Merged

Switch to secure signing algorithm for SSH secrets engine #14006

merged 6 commits into from
Feb 18, 2022

Commits on Feb 18, 2022

  1. Explicitly call out SSH algorithm_signer default 

    Related: #11608

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    3f2e577 View commit details
    Browse the repository at this point in the history

  2. Use rsa-sha2-256 as the default SSH CA hash algo 

    As mentioned in the OpenSSH 8.2 release notes, OpenSSH will no longer be
accepting ssh-rsa signatures by default as these use the insecure SHA-1
algorithm.

For roles in which an explicit signature type wasn't specified, we
should change the default from SHA-1 to SHA-256 for security and
compatibility with modern OpenSSH releases.

See also: https://www.openssh.com/txt/release-8.2

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    276a5a4 View commit details
    Browse the repository at this point in the history

  3. Update docs mentioning new algorithm change 

    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    e620e2d View commit details
    Browse the repository at this point in the history

  4. Add changelog entry 

    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    c156b18 View commit details
    Browse the repository at this point in the history

  5. Fix missing parenthesis, clarify new default value

    @cipherboy
    cipherboy committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    78971e9 View commit details
    Browse the repository at this point in the history

  6. Add to side bar 

    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    679e445 View commit details
    Browse the repository at this point in the history