Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VAULT-5813] Remove duplicate sha_256 in SystemCatalogRequest OAS #15163

Merged
merged 4 commits into from
Apr 25, 2022

Conversation

AnPucel
Copy link
Contributor

@AnPucel AnPucel commented Apr 25, 2022

Currently, there is a duplicate sha256 and sha_256 field in the OpenApi Spec for SystemCatalogRequest. This causes issues for codegen because they get mapped to the same variable name. We're removing the sha_256 in the OpenApi spec to avoid this.

@AnPucel AnPucel requested a review from a team April 25, 2022 18:04
@AnPucel AnPucel changed the title Remove duplicate sha_256 in SystemCatalogRequest [VAULT-5813] Remove duplicate sha_256 in SystemCatalogRequest Apr 25, 2022
@AnPucel AnPucel changed the title [VAULT-5813] Remove duplicate sha_256 in SystemCatalogRequest [VAULT-5813] Remove duplicate sha_256 in SystemCatalogRequest OAS Apr 25, 2022
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the comment 👍

@AnPucel AnPucel merged commit 32c7438 into main Apr 25, 2022
@AnPucel AnPucel deleted the anpucel/OASDupeFields branch April 25, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants