Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading MFA configs upont restart #15261

Merged
merged 4 commits into from
May 5, 2022

Conversation

hghaf099
Copy link
Contributor

@hghaf099 hghaf099 commented May 2, 2022

Addresses #15108
MFA methods/enforcements are not loaded after restarting all nodes

@hghaf099 hghaf099 requested a review from ncabatoff May 2, 2022 23:30
@hghaf099 hghaf099 marked this pull request as ready for review May 5, 2022 20:08
@hghaf099 hghaf099 requested a review from ccapurso May 5, 2022 20:08
vault/core.go Outdated Show resolved Hide resolved
Co-authored-by: Chris Capurso <1036769+ccapurso@users.noreply.github.com>
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@hghaf099 hghaf099 merged commit 70b46ea into main May 5, 2022
@hghaf099 hghaf099 deleted the load-login-mfa-config-to-memdb-upon-startup branch May 5, 2022 22:54
@hghaf099
Copy link
Contributor Author

hghaf099 commented May 5, 2022

Ah, I forgot to label this with backports. I guess that was going to fail anyways. I am going to manually backport it to 1.10

hghaf099 added a commit that referenced this pull request May 5, 2022
* loading MFA configs upont restart

* Adding CL

* feedback

* Update vault/core.go

Co-authored-by: Chris Capurso <1036769+ccapurso@users.noreply.github.com>

Co-authored-by: Chris Capurso <1036769+ccapurso@users.noreply.github.com>
hghaf099 added a commit that referenced this pull request May 6, 2022
* loading MFA configs upont restart

* Adding CL

* feedback

* Update vault/core.go

Co-authored-by: Chris Capurso <1036769+ccapurso@users.noreply.github.com>

Co-authored-by: Chris Capurso <1036769+ccapurso@users.noreply.github.com>

Co-authored-by: Chris Capurso <1036769+ccapurso@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants