Added support for VAULT_PROXY_ADDR + Updated docs #15377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated documentation to describe the behavior when supplying `VAULT_HTTP_PROXY`. Also added support for `VAULT_PROXY_ADDR` as a 'better name' for `VAULT_HTTP_PROXY`.
Change is in addition to existing change
Related to GH issue raised regarding behavior for Vault proxy env var.
taoism4504
reviewed
May 15, 2022
taoism4504
reviewed
May 15, 2022
taoism4504
reviewed
May 15, 2022
taoism4504
approved these changes
May 15, 2022
Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
ncabatoff
approved these changes
May 20, 2022
There was a problem hiding this comment.
I'm not 100% convinced that the better name is worth having two different ways to do something and the potential confusion that introduces. That said, I like the tests and the docs, and my minor misgivings aren't enough for me to reject this. Perhaps in time we could retire the old name.
As raised in a PR comment, we don't need to call ReadEnvironment() as the DefaultConfig() does that for us. We can just check the config.Error for the error.
ncabatoff
reviewed
May 20, 2022
ncabatoff
reviewed
May 20, 2022
ncabatoff
reviewed
May 20, 2022
Yes, ideally we could get rid of the |
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
Updated documentation to describe the behavior when supplying `VAULT_HTTP_PROXY`. Also added support for `VAULT_PROXY_ADDR` as a 'better name' for `VAULT_HTTP_PROXY`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated documentation to describe the behavior when supplying
VAULT_HTTP_PROXY.Also added support for
VAULT_PROXY_ADDRas a 'better name' forVAULT_HTTP_PROXY.