Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to stored license #15513

Merged
merged 4 commits into from
May 20, 2022
Merged

Conversation

arnav28
Copy link
Contributor

@arnav28 arnav28 commented May 19, 2022

  • Stored license was deprecated in 1.8 and from 1.11 all licenses will be
    auto loaded.

- Stored license was deprecated in 1.8 and from 1.11 all licenses will be
auto loaded.
@arnav28 arnav28 added the ui label May 19, 2022
@arnav28 arnav28 added this to the 1.11.0-rc1 milestone May 19, 2022
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe beyond the scope, but the property autoloaded is a boolean and used in more files throughout the app. The boolean no longer makes sense (I don't believe) so should this be changed? This is a question, because maybe I'm missing something but the definition of the autoloaded property is " Whether the license is autoloaded." maybe there are more than two options—a third I'm unaware of and if such then the property still makes sense.

@arnav28
Copy link
Contributor Author

arnav28 commented May 19, 2022

Maybe beyond the scope, but the property autoloaded is a boolean and used in more files throughout the app. The boolean no longer makes sense (I don't believe) so should this be changed? This is a question, because maybe I'm missing something but the definition of the autoloaded property is " Whether the license is autoloaded." maybe there are more than two options—a third I'm unaware of and if such then the property still makes sense.

Yup, I was planning to remove the autoloaded boolean but then noticed that we have something called persisted_autoload. Honestly not sure what the difference is!!

@arnav28 arnav28 merged commit b8f449a into main May 20, 2022
@arnav28 arnav28 deleted the ui/VAULT-5702/remove-stored-license branch May 20, 2022 16:33
Gabrielopesantos pushed a commit to Gabrielopesantos/vault that referenced this pull request Jun 6, 2022
* Remove reference to stored license

- Stored license was deprecated in 1.8 and from 1.11 all licenses will be
auto loaded.

* Added changelog

* Remove test for stored license

* Add defensive check in serializer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants