VAULT-6131 OpenAPI schema now includes /auth/token endpoints when explicit permission has been granted #15552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licit permission has been granted
swayne275
approved these changes
May 20, 2022
There was a problem hiding this comment.
We'd discussed and this seems to be the right thing, but I lack a bit of context. Waiting for @ncabatoff is a good idea
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
…licit permission has been granted (hashicorp#15552) * VAULT-6131 OpenAPI schema now includes /auth/token endpoints when explicit permission has been granted * VAULT-6131 add changelog * VAULT-6131 Update changelog and fix related bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this code path was checking for ACLs for "/token/" when it should have been checking for "/auth/token". The
Core.mounts.EntriesandCore.auth.Entriesboth get checked byhasAccess, and while theMountEntryformountswas simplymounts, which should not be prepended to e.g./sys/,authdoes need to be prepended for/auth/tokenetc.Blanket access (e.g. access to
/auth/token/*) goes down a different code path, which is why this issue was not seen in that case.The OpenAPI schema now contains information about the
/auth/token/endpoints if explicit permission is granted to at least one of them (same behaviour as other endpoints).