Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client count timezone fix #15743

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Conversation

arnav28
Copy link
Contributor

@arnav28 arnav28 commented Jun 1, 2022

This is the backport for #15167
Client count went through major refactoring in 1.10 and as a result straightforward backport was not possible.

Client count went through major refactoring in 1.10 and as a result
straightforward backport was not possible.
@arnav28 arnav28 added ui bug Used to indicate a potential bug labels Jun 1, 2022
@arnav28 arnav28 added this to the 1.9.7 milestone Jun 1, 2022
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this ticket closed! 🚀

// TODO: Replace with formatRFC3339 when date-fns is updated
// converts to milliseconds, divide by 1000 to get epoch
params.start_time = getTime(startDate) / 1000;
params.start_time = formatRFC3339(startDate);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@arnav28 arnav28 merged commit 379bf00 into release/1.9.x Jun 1, 2022
@arnav28 arnav28 deleted the ui/clientcount-timezone-bug branch June 1, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants