Change tooltip for token_bound_certs and glimmerize string-list component #15852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
commented
Jun 7, 2022
| @@ -0,0 +1,56 @@ | |||
| <div | |||
There was a problem hiding this comment.
I moved the location of this file so we don't need to use the layout extension in the core/addon.
Monkeychip
commented
Jun 7, 2022
| @@ -17,6 +17,7 @@ | |||
| "ember-composable-helpers": "*", | |||
| "ember-concurrency": "*", | |||
| "ember-maybe-in-element": "*", | |||
| "ember/render-modifiers": "*", | |||
There was a problem hiding this comment.
allows me to use did-render and did-update inside the hbs file
arnav28
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the tokenBoundCerts string-list helpText. Request from HCP.
It also glimmerizes the string-list component.
If the attr.name is tokenBoundCidrs then the help text is modified from the same helpText used on the CLI and API.
Now:
Before:
